Add housekeeping leadership subscription - #8466
Open
hardillb wants to merge 2 commits into
Open
Conversation
It appears the leadership subscription was missed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8466 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 460 460
Lines 24736 24736
Branches 6595 6595
=======================================
Hits 18980 18980
Misses 5756 5756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hardillb
marked this pull request as draft
September 10, 2026 12:46
Contributor
Author
|
Noticed while reviewing #8450 that we might not have a clean shutdown publish to remove the leader vote. Will fix before removing draft status |
Contributor
Author
|
Nevermind, found it Line 124 in 37fcff2 |
hardillb
marked this pull request as ready for review
September 10, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It appears the leadership subscription was missed when implemented.